fix(dataconnect): fix deserialization of emulator gRPC error codes into detailed errors#3180
fix(dataconnect): fix deserialization of emulator gRPC error codes into detailed errors#3180stephenarosaj wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds support for handling gRPC-to-HTTP transcoded error responses in the Data Connect API client by mapping numeric gRPC status codes to their string equivalents. It also updates .gitignore to exclude local debug logs and adds a unit test to verify the new error-handling behavior. A critical issue was identified in the error parsing logic where a null error property in the response could lead to a TypeError and crash the error-handling flow; a code suggestion was provided to safely handle this scenario.
|
|
||
| const error: ServerError = (response.data as ErrorResponse).error || {}; | ||
| const data = response.data as any; | ||
| const error: ServerError = (validator.isNonNullObject(data) && 'error' in data) ? data.error : data || {}; |
There was a problem hiding this comment.
If the response data contains a null error property (e.g., { "error": null }), validator.isNonNullObject(data) && 'error' in data will evaluate to true. This results in error being assigned null. On the subsequent line, accessing error.status will throw a TypeError: Cannot read properties of null (reading 'status'), crashing the error-handling flow.
To prevent this, ensure that data.error is also a non-null object before assigning it, and fallback to data (if it is a non-null object) or {} otherwise.
| const error: ServerError = (validator.isNonNullObject(data) && 'error' in data) ? data.error : data || {}; | |
| const error: ServerError = (validator.isNonNullObject(data) && validator.isNonNullObject(data.error)) ? data.error : (validator.isNonNullObject(data) ? data : {}); |
Description
✨ Added gRPC status code mapping to ensure error responses from the local Data Connect emulator are correctly deserialized. Before these changes, when using the emulator, errors are improperly deserialized into
unknown-errorDataConnectErrors errors instead of ones with detailedcodeandmessagefields.Changes
GRPC_STATUS_CODE_TO_STRINGmapping dictionarytoFirebaseErrorto handle root-level gRPC error responses.gitignoreTesting