fix: Using Java 8 in release and nightly builds - #573
Merged
Conversation
lahirumaramba
approved these changes
Jun 14, 2021
lahirumaramba
left a comment
Member
There was a problem hiding this comment.
Great! Thanks, Hiranya!
LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible to upgrade a wide range of the tools/dependencies we use. We will continue to compile source down to Java 1.7 compatibility (required config already present in
pom.xml), and therefore the resulting artifacts will work on Java 7. Added Java 7, 8 and 11 to the CI build matrix for added coverage.Environment variable manipulation in tests do not work on Java 8 and above, and therefore implemented some workarounds for that too.