Skip to content

feat(auth): enables OIDC auth code flow - #532

Merged
lsirac merged 6 commits into
masterfrom
codeflow
May 11, 2021
Merged

feat(auth): enables OIDC auth code flow#532
lsirac merged 6 commits into
masterfrom
codeflow

Conversation

@lsirac

@lsirac lsirac commented Apr 27, 2021

Copy link
Copy Markdown
Contributor

Provides an option for developers to specify the OAuth response type for their OIDC provider (either one of these can be set:):

  • id_token
  • code (if set, must also set the client secret)

@lsirac
lsirac requested review from egilmorez and hiranya911 April 27, 2021 23:58
@hiranya911 hiranya911 changed the title feat: enables OIDC auth code flow feat(auth): enables OIDC auth code flow May 11, 2021
hiranya911
hiranya911 approved these changes May 11, 2021
View reviewed changes

@hiranya911 hiranya911 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍

egilmorez
egilmorez approved these changes May 11, 2021
View reviewed changes

@egilmorez egilmorez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, thanks!

@lsirac
lsirac merged commit 6962561 into master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@hiranya911 hiranya911 hiranya911 approved these changes
@egilmorez egilmorez egilmorez approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@egilmorez egilmorez

Labels

release-note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lsirac @hiranya911 @egilmorez