Update doc string for dryRun in FCM send methods. - #509
Merged
Conversation
…annot be used to validate APNS tokens.
egilmorez
reviewed
Jan 14, 2021
egilmorez
left a comment
Contributor
There was a problem hiding this comment.
Thanks Chong! A couple nits for you.
| * FCM performs all the necessary validations, and emulates the send operation. | ||
| * FCM performs all the necessary validations, and emulates the send operation. {@code dryRun} | ||
| * option is useful for validating if an FCM registration has been deleted. But it cannot be used | ||
| * to validate APNS tokens. |
| * | ||
| * <p>If the {@code dryRun} option is set to true, the messages will not be actually sent. Instead | ||
| * FCM performs all the necessary validations, and emulates the send operation. | ||
| * <p>If the {@code dryRun} option is set to true, the message will not be actually sent. Instead |
Contributor
Author
|
Friendly ping :) (Sorry I think I forgot to client the re-request review button) |
egilmorez
approved these changes
Feb 18, 2021
egilmorez
left a comment
Contributor
There was a problem hiding this comment.
LG, some optional nits to consider. Thanks!
Contributor
Author
|
Thanks Eric! |
This was referenced Mar 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update doc string for dryRun in FCM send methods to mention that it cannot be used to validate APNS tokens.