Skip to content

Refactor user test utilities and use TemporaryUser in tenant-aware integration tests. - #432

Merged
micahstairs merged 1 commit into
idp-configfrom
micahstairs-temporary-user
Jun 4, 2020
Merged

Refactor user test utilities and use TemporaryUser in tenant-aware integration tests.#432
micahstairs merged 1 commit into
idp-configfrom
micahstairs-temporary-user

Conversation

@micahstairs

Copy link
Copy Markdown
Contributor

I've refactored the test utilities we use for users in order to reduce code duplication, and I've also made TenantAwareFirebaseAuthIT use TemporaryUser.

@hiranya911 hiranya911 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hiranya911 hiranya911 assigned micahstairs and unassigned hiranya911 Jun 4, 2020
@micahstairs
micahstairs merged commit e1e49e3 into idp-config Jun 4, 2020
@micahstairs
micahstairs deleted the micahstairs-temporary-user branch June 4, 2020 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants