Finish implementing SAML provider config. - #428
Merged
Conversation
hiranya911
suggested changes
May 29, 2020
hiranya911
left a comment
Contributor
There was a problem hiding this comment.
Let's remove the signReuqest stuff for now. Other changes LGTM.
micahstairs
added a commit
that referenced
this pull request
Jun 12, 2020
I've implemented addAllX509Certificates and removed the TODOs for the request signing, since we are not ready to expose that yet. I've also added unit tests for SamlProviderConfig.UpdateRequest, because those were missed in a previous PR. On an unrelated note, I've also added a comment describing why 'suppressLoadErrors' needs to be set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've implemented
addAllX509Certificatesand removed the TODOs for the request signing, since we are not ready to expose that yet.I've also added unit tests for SamlProviderConfig.UpdateRequest, because those were missed in a previous PR.
On an unrelated note, I've also added a comment describing why 'suppressLoadErrors' needs to be set.