Skip to content

Add operation to update SAML provider configs. - #424

Merged
micahstairs merged 3 commits into
idp-configfrom
micahstairs-update-saml
May 27, 2020
Merged

Add operation to update SAML provider configs.#424
micahstairs merged 3 commits into
idp-configfrom
micahstairs-update-saml

Conversation

@micahstairs

Copy link
Copy Markdown
Contributor

Adds an update operation for SAML provider configs. I've included both unit tests and integration tests.

@hiranya911 hiranya911 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple of nits.

Comment thread src/main/java/com/google/firebase/auth/FirebaseUserManager.java Outdated
Comment thread src/test/java/com/google/firebase/auth/FirebaseUserManagerTest.java
Comment thread src/test/java/com/google/firebase/auth/FirebaseUserManagerTest.java
@hiranya911 hiranya911 assigned micahstairs and unassigned hiranya911 May 26, 2020
@micahstairs
micahstairs merged commit c3a08b4 into idp-config May 27, 2020
@micahstairs
micahstairs deleted the micahstairs-update-saml branch May 27, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants