Add operation to list OIDC provider configs. - #404
Merged
Conversation
micahstairs
commented
May 4, 2020
hiranya911
suggested changes
May 4, 2020
hiranya911
left a comment
Contributor
There was a problem hiding this comment.
Looks pretty good. Only minor nits.
micahstairs
added a commit
that referenced
this pull request
Jun 12, 2020
This adds an operation to list OIDC provider configs (can be done using either the tenant-aware or standard Firebase client). This work is part of adding multi-tenancy support (see issue #332).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an operation to list OIDC provider configs (can be done using either the tenant-aware or standard Firebase client). This is the last OIDC provider config operation that needs to be implemented.
This work is part of adding multi-tenancy support (see issue #332).
Please take note of the generics I have chosen to use in ListProviderConfigsPage. This should help reduce a lot of code duplication when it comes time to add support for SAML provider configs.