Skip to content

Add OIDC Auth provider config class - #397

Merged
micahstairs merged 2 commits into
idp-configfrom
micahstairs-provider-config
Apr 27, 2020
Merged

Add OIDC Auth provider config class#397
micahstairs merged 2 commits into
idp-configfrom
micahstairs-provider-config

Conversation

@micahstairs

Copy link
Copy Markdown
Contributor

This provider class only includes a CreateRequest inner class for the time being. An UpdateRequest inner class will be added in the future.

In addition to OidcProviderConfig, this pull request also includes a base class, which will be shared by a future SamlProviderConfig class.

This is part of adding multi-tenancy support (see issue #332).

@hiranya911 hiranya911 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a suggestion

Comment thread src/main/java/com/google/firebase/auth/OidcProviderConfig.java
@hiranya911 hiranya911 assigned micahstairs and unassigned hiranya911 Apr 24, 2020
@hiranya911 hiranya911 assigned micahstairs and unassigned hiranya911 Apr 27, 2020
@micahstairs
micahstairs merged commit 3827819 into idp-config Apr 27, 2020
@micahstairs
micahstairs deleted the micahstairs-provider-config branch April 27, 2020 20:34
micahstairs added a commit that referenced this pull request Apr 27, 2020
Adds OIDC provider config class and base class. This is part of adding multi-tenancy support (see issue #332).
micahstairs added a commit that referenced this pull request Jun 12, 2020
Adds OIDC provider config class and base class. This is part of adding multi-tenancy support (see issue #332).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants