Testable BatchResponse - #389
Merged
lahirumaramba merged 3 commits intoApr 10, 2020
Merged
Conversation
- Converts batch response to an interface - Moves batch response implementation to BatchResponseImpl - Update FirebaseMessagingClientImpl to use BatchResponseImpl - Updated tests
hiranya911
suggested changes
Apr 10, 2020
hiranya911
left a comment
Contributor
There was a problem hiding this comment.
Looks reasonable to me with just one change suggested.
@lahirumaramba what do you think?
Contributor
|
Hey @ToxicBakery. I just pushed a change to our CI config, so that they will be run on external contributions such as this PR. Can I ask you to please sync against the latest master branch, and make a push? |
Contributor
Author
|
Done, appears to have run successfully 👍 |
hiranya911
approved these changes
Apr 10, 2020
hiranya911
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍
@lahirumaramba I'll leave this to you to review and merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #388