Skip to content

fix(fcm): Fix issues in event_time timestamp parsing - #338

Merged
chong-shao merged 4 commits into
masterfrom
fix_timestamp
Dec 19, 2019
Merged

fix(fcm): Fix issues in event_time timestamp parsing#338
chong-shao merged 4 commits into
masterfrom
fix_timestamp

Conversation

@chong-shao

@chong-shao chong-shao commented Dec 19, 2019

Copy link
Copy Markdown
Contributor
  • Set the timezone to always be UTC.
  • Pending zeros after the millisecond digits to the right instead of left.

RELEASE NOTE: AndroidNotification class now correctly formats the event_time field sent to the Cloud Messaging service.

Resolves #337

@hiranya911 hiranya911 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one typo/bug pointed out.

Comment thread src/main/java/com/google/firebase/messaging/AndroidNotification.java Outdated
@hiranya911 hiranya911 changed the title Fix issues in event_time timestamp parsing fix(fcm): Fix issues in event_time timestamp parsing Dec 19, 2019

@hiranya911 hiranya911 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chong-shao
chong-shao merged commit 78852a9 into master Dec 19, 2019
@chong-shao
chong-shao deleted the fix_timestamp branch December 19, 2019 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect timestamp format in AndroidNotification.event_time

2 participants