Skip to content

Fixing some failing RTDB tests - #334

Merged
hiranya911 merged 3 commits into
masterfrom
hkj-test-fix
Dec 12, 2019
Merged

Fixing some failing RTDB tests#334
hiranya911 merged 3 commits into
masterfrom
hkj-test-fix

Conversation

@hiranya911

@hiranya911 hiranya911 commented Dec 12, 2019

Copy link
Copy Markdown
Contributor

Following test failures are observed when running on environments not set up for ADC:

testDbUrlIsEmulatorUrlForDbRefWithPath(com.google.firebase.database.FirebaseDatabaseTest)  Time elapsed: 0.13 sec  <<< ERROR!
java.lang.IllegalStateException: java.io.IOException: The Application Default Credentials are not available. They are available if running in Google Compute Engine. Otherwise, the environment variable GOOGLE_APPLICATION_CREDENTIALS must be defined pointing to a file defining the credentials. See https://developers.google.com/accounts/docs/application-default-credentials for more information.
	at com.google.firebase.database.FirebaseDatabaseTest.testDbUrlIsEmulatorUrlForDbRefWithPath(FirebaseDatabaseTest.java:252)
Caused by: java.io.IOException: The Application Default Credentials are not available. They are available if running in Google Compute Engine. Otherwise, the environment variable GOOGLE_APPLICATION_CREDENTIALS must be defined pointing to a file defining the credentials. See https://developers.google.com/accounts/docs/application-default-credentials for more information.
	at com.google.firebase.database.FirebaseDatabaseTest.testDbUrlIsEmulatorUrlForDbRefWithPath(FirebaseDatabaseTest.java:252)

testDbUrlIsEmulatorUrlWhenSettingOptionsManually(com.google.firebase.database.FirebaseDatabaseTest)  Time elapsed: 0.001 sec  <<< ERROR!
java.lang.IllegalStateException: java.io.IOException: The Application Default Credentials are not available. They are available if running in Google Compute Engine. Otherwise, the environment variable GOOGLE_APPLICATION_CREDENTIALS must be defined pointing to a file defining the credentials. See https://developers.google.com/accounts/docs/application-default-credentials for more information.
	at com.google.firebase.database.FirebaseDatabaseTest.testDbUrlIsEmulatorUrlWhenSettingOptionsManually(FirebaseDatabaseTest.java:215)
Caused by: java.io.IOException: The Application Default Credentials are not available. They are available if running in Google Compute Engine. Otherwise, the environment variable GOOGLE_APPLICATION_CREDENTIALS must be defined pointing to a file defining the credentials. See https://developers.google.com/accounts/docs/application-default-credentials for more information.
	at com.google.firebase.database.FirebaseDatabaseTest.testDbUrlIsEmulatorUrlWhenSettingOptionsManually(FirebaseDatabaseTest.java:215)

This PR fixes these issues by using explicit credentials.

@micahstairs

micahstairs commented Dec 12, 2019

Copy link
Copy Markdown
Contributor

Thanks! I've tested this on my machine (which was failing before) and this seems to work now.

sarajmunjal
sarajmunjal approved these changes Dec 12, 2019
View reviewed changes
Comment thread src/test/java/com/google/firebase/database/FirebaseDatabaseTest.java Outdated
GoogleCredentials credentials = GoogleCredentials.fromStream(ServiceAccount.EDITOR.asStream());
FirebaseOptions options = FirebaseOptions.builder()
.setCredentials(credentials)
.build();

@sarajmunjal sarajmunjal Dec 12, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: We can put this in a helper method and re-use across tests.

@hiranya911 hiranya911 Dec 12, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Refactored the options into a static constant.

@hiranya911
hiranya911 merged commit 0d9b27e into master Dec 12, 2019
@hiranya911
hiranya911 deleted the hkj-test-fix branch December 12, 2019 23:10
@micahstairs micahstairs mentioned this pull request Jan 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@sarajmunjal sarajmunjal sarajmunjal approved these changes
@micahstairs micahstairs micahstairs approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@hiranya911 hiranya911

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hiranya911 @micahstairs @sarajmunjal