fix(fcm): Increase the multicast request count limit to 500. - #321
Conversation
|
@chong-shao is n't it better to make this configurable ? |
|
Hi @Bonythomasv We are experimenting with the 1000 limit and we would like to set the recommended maximum size in our SDK to be 500 for now.
|
|
@chong-sao. Are you seeing any knows issues with 1000 ? We used the FCM http directly, we send 100s services per API call and but we would like to switch to admin sdk and this 500 hard limit is going to be a problem for us. Can I PR to make this configurable with default value as 500 |
|
FCM v1 API only supported 100 messages per batch until a few days ago. It's the legacy FCM API that supported batches of up to 1000. We want to get the v1 API limit bumped up to 1000, but we want to do it in phases. So until all SDKs are there, we'd advise users to not send batches larger than 500 to the v1 API. PS: We also don't want this to be a configurable limit. It needs to be enforced as a hard limit. |
|
Ah.. I see , we still uses the legacy API.
One side question,
The does v1 API response has the API message delivery status, or is there
any way to find number of failed devices by multicast_id or message_id in
the response.
…On Wed, Oct 23, 2019, 6:54 PM Hiranya Jayathilaka ***@***.***> wrote:
FCM v1 API only supported 100 messages per batch until a few days ago.
It's the legacy FCM API that supported batches of up to 1000. We want to
get the v1 API limit bumped up to 1000, but we want to do it in phases. So
until all SDKs are there, we'd advise users to not send batches larger than
500 to the v1 API.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#321?email_source=notifications&email_token=ADZVKSQVPCSXONDBW6355G3QQDPZRA5CNFSM4JDY3PT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECDHQWI#issuecomment-545683545>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADZVKSS7ZZVYN5CDNXOWLCLQQDPZRANCNFSM4JDY3PTQ>
.
|
Increase the multicast request count limit to 500.
Testing
RELEASE NOTE: Number of messages per batch increased to 500.