feat(fcm): Add 12 new android notification params support - #320
Merged
Conversation
Member
|
Thanks @chong-shao! |
Contributor
Author
|
Opps I forgot to add DefaultLightSettings .. We should include it. Will add it soon |
Contributor
Author
|
Added DefaultLightSettings. |
hiranya911
suggested changes
Oct 17, 2019
hiranya911
left a comment
Contributor
There was a problem hiding this comment.
Looks mostly good. Make sure the public APIs accept primitives whenever possible. And I thought some of the builders were slightly overkill.
hiranya911
suggested changes
Oct 19, 2019
hiranya911
left a comment
Contributor
There was a problem hiding this comment.
Thanks for making the changes. This is very close to being done. Just a few nits to address.
hiranya911
suggested changes
Oct 21, 2019
hiranya911
left a comment
Contributor
There was a problem hiding this comment.
Thanks. Looks pretty good. Just a last couple of nits.
Contributor
|
@egilmorez please take a look at the API doc components of this PR. |
hiranya911
approved these changes
Oct 21, 2019
hiranya911
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Please wait for @lahirumaramba and @egilmorez to make a pass.
egilmorez
reviewed
Oct 22, 2019
egilmorez
reviewed
Oct 22, 2019
egilmorez
reviewed
Oct 22, 2019
egilmorez
reviewed
Oct 22, 2019
egilmorez
reviewed
Oct 22, 2019
egilmorez
reviewed
Oct 22, 2019
egilmorez
reviewed
Oct 22, 2019
egilmorez
reviewed
Oct 22, 2019
egilmorez
reviewed
Oct 22, 2019
egilmorez
reviewed
Oct 22, 2019
egilmorez
reviewed
Oct 22, 2019
egilmorez
left a comment
Contributor
There was a problem hiding this comment.
Some suggests for you Chong.
Thanks!
egilmorez
approved these changes
Oct 22, 2019
egilmorez
left a comment
Contributor
There was a problem hiding this comment.
LG Chong, thanks!
(I should have know that backticks don't work in Javadoc :) )
hiranya911
suggested changes
Oct 28, 2019
hiranya911
left a comment
Contributor
There was a problem hiding this comment.
Just one comment about setter names. Then we can merge.
…xpected value of eventTime does not depend on the machine's local timezone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 12 new android notification params support
Testing
API Changes
RELEASE NOTE: Added a series of new parameters to the
AndroidNotificationclass that allow further customization of notifications that target Android devices.