Skip to content

FirebaseAuth Email Action Links API - #232

Merged
hiranya911 merged 14 commits into
masterfrom
hkj-email-action
Dec 19, 2018
Merged

FirebaseAuth Email Action Links API#232
hiranya911 merged 14 commits into
masterfrom
hkj-email-action

Conversation

@hiranya911

@hiranya911 hiranya911 commented Dec 5, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

go/email-action-links

Adds following new methods to FirebaseAuth API:

String generatePasswordResetLink(String email)
String generatePasswordResetLink(String email, ActionCodeSettings settings)
String generateEmailVerificationLink(String email)
String generateEmailVerificationLink(String email, ActionCodeSettings settings)
String generateSignInWithEmailLink(String email, ActionCodeSettings settings)
ApiFuture<String> generatePasswordResetLinkAsync(String email)
ApiFuture<String> generatePasswordResetLinkAsync(String email, ActionCodeSettings settings)
ApiFuture<String> generateEmailVerificationLinkAsync(String email)
ApiFuture<String> generateEmailVerificationLinkAsync(String email, ActionCodeSettings settings)
ApiFuture<String> generateSignInWithEmailLinkAsync(String email, ActionCodeSettings settings)

@hiranya911
hiranya911 requested a review from bklimt December 18, 2018 21:17
bklimt
bklimt reviewed Dec 19, 2018
View reviewed changes
Comment thread src/test/java/com/google/firebase/auth/FirebaseAuthIT.java
return result;
}

private String randomPhoneNumber() {

@bklimt bklimt Dec 19, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably put this next to RandomUser, or maybe even as a static method on that class, just to make it easier to find.

bklimt
bklimt approved these changes Dec 19, 2018
View reviewed changes

@bklimt bklimt left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiranya911 hiranya911 assigned hiranya911 and unassigned bklimt Dec 19, 2018
@hiranya911
hiranya911 merged commit 5238381 into master Dec 19, 2018
@hiranya911
hiranya911 deleted the hkj-email-action branch December 19, 2018 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@bklimt bklimt bklimt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@hiranya911 hiranya911

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hiranya911 @bklimt