Minor Updates to pom.xml - #16
Merged
Merged
Conversation
…tegration tests during release:perform (they are executed once in release:prepare)
mikelehen
approved these changes
Apr 21, 2017
mikelehen
left a comment
There was a problem hiding this comment.
LGTM though consider using a more verbose flag name.
|
|
||
| ``` | ||
| mvn verify -Dfirebase.it.certificate=path/to/your/serviceAccount.json -Dskip.surefire.tests=true | ||
| mvn verify -Dfirebase.it.certificate=path/to/your/serviceAccount.json -DskipUTs |
There was a problem hiding this comment.
Is this an existing convention? Or could we spell this out as skipUnitTests (which I think would be much clearer)? :-)
Contributor
Author
There was a problem hiding this comment.
Maven failsafe plugin which is in charge of running integration tests supports a skipITs flag out of the box. I thought we could support a similarly named flag for skipping unit tests. WDYT?
There was a problem hiding this comment.
OK, cool. If it's an existing convention I'm fine with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minor changes to pom.xml based on today's release experience.
Adding a flag to disable unit tests and integration tests separately
-DskipITs(skips integration tests; flag provided by maven failsafe plugin)-DskipUTs(skips unit tests; custom flag added to pom.xml)Also the failsafe plugin knows to look for *IT.java tests. We don't have to explicitly mention it in the pom.
Skipping integration tests in the release profile
Maven-based release is conducted in 2 main steps:
mvn release:preparemvn release:performThe
preparestep builds and runs all tests (both unit and integration) before tagging the source in GitHub. Theperformstep grabs the source from the tag, and proceeds to build and test it again. Therefore we end up running the integration test suite twice during the release process which is redundant and takes time. This PR sets theskipITsflag in the release profile which essentially skips integration tests duringrelease:perform.