Conversation
…maller description for README
prehner
requested changes
Dec 13, 2022
Contributor
prehner
left a comment
There was a problem hiding this comment.
Exciting update. More performance with only compile times as downside! I have some suggestions to reduce boilerplate in the benchmarks.
… typos. Co-authored-by: Philipp Rehner <69816385+prehner@users.noreply.github.com>
prehner
approved these changes
Dec 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
dual_numbersprovides evaluations of the Helmholtz energy function for different dual number types without constructing aStateobject.state_propertiesprovides benchmarks for different properties (compressibility, molar_volumes, fugacity coefficient, and isochoric heat capacity for now). TheStateis constructed within the function that is evaluated for the benchmarks but conditions are given in the natural variables of the Helmholtz energy so that no density iteration has to be conducted.This PR changes the Cargo profile of the workflow we use to build and publish python wheels to include LTO.
In the future, it might be interesting to also investigate the different contributions for PC-SAFT separately or add additional benchmarks for different pure substances and mixtures.