Add critical_temperature argument to VaporPressure constructor#86
Merged
Add critical_temperature argument to VaporPressure constructor#86
critical_temperature argument to VaporPressure constructor#86Conversation
…or. Add estimator module to documentation
critical_temperature argument to VaporPressure constructor
prehner
approved these changes
Dec 13, 2022
Contributor
prehner
left a comment
There was a problem hiding this comment.
Excellent stuff! I tried it on a larger dataset and it works as intended. Nice compromise between robustness and flexibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new optional argument to the constructors of
VaporPressureandDataSet.vapor_pressure, i.e. the critical temperature.If provided, it is used as initial temperature when calculating the critical point in the
predictmethod.If not provided, the maximum temperature of the input temperatures is used.
If the calculation of the critical point within
predictfails (using either the provided or maximum temperature), another call to the method using the default temperatures is used.Did some cleanup of the documentation and added
eos.estimatorto the documentation.