Add LM regression for parameter optimization in Rust#350
Draft
Add LM regression for parameter optimization in Rust#350
Conversation
…tances and mixtures (selected properties)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds parameter optimization utilities to
feos-coreand exposesRegressorobjects to Python.Everything works, but there is still some WIP (what methods and properties to expose, naming of methods/modules).
Todos
FeosError. Either as variant inFeosErroror we bring the variants over toFeosError.Open Decisions
rayonfeature gate for convenience. Is there a case/need for optimization without rayon?ParametersADtrait quite a bit. Tried to resolve the "parameter order and indexing" synchronisation problem. We can discuss whether that change is appropriate and if we want a different interface.ParametersADtrait: should we add the option to blacklist parameters for AD? E.g. association sites (although there is currently an example that takes the derivative w.r.t those). I added the option - not sure we want to keep it. Currently there is the option but it not applied.AI usage
Usage Python
Output (250 vapor pressures and 250 liquid densities for hexane):
Usage Rust
generates this output: