Skip to content
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
include phase fraction in PhaseEquilibrium
  • Loading branch information
prehner committed Mar 15, 2026
commit c33df5910cff0b02fc73f8a6738c17965be6c79c
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Test

on:
push:
branches: [main, development]
branches: [main]
pull_request:
branches: [main, development]

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/wheels.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Build Wheels
on:
push:
branches: [main, development]
branches: [main]
pull_request:
branches: [main, development]
jobs:
Expand Down
9 changes: 8 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Breaking]
### Added
- Extended tp-flash algorithm to static numbers of components and enabled automatic differentiation for binary systems. [#336](https://github.com/feos-org/feos/pull/336)
- Rewrote `PhaseEquilibrium::pure_p` to mirror `pure_t` and enable automatic differentiation. [#337](https://github.com/feos-org/feos/pull/337)
- Rewrote `PhaseEquilibrium::pure_p` to mirror `pure_t` and enabled automatic differentiation. [#337](https://github.com/feos-org/feos/pull/337)
- Added `boiling_temperature` to the list of properties for parallel evaluations of gradients. [#337](https://github.com/feos-org/feos/pull/337)
- Added the `Composition` trait to allow more flexibility in the creation of states and phase equilibria. [#330](https://github.com/feos-org/feos/pull/330)

### Changed
- Removed any assumptions about the total number of moles in a `State` or `PhaseEquilibrium`. Evaluating extensive properties now returns a `Result`. [#330](https://github.com/feos-org/feos/pull/330)

### Removed
- Removed the `StateBuilder` struct, because it is mostly obsolete with the addition of the `Composition` trait. [#330](https://github.com/feos-org/feos/pull/330)

### Packaging
- Updated `quantity` dependency to 0.13 and removed the `typenum` dependency. [#323](https://github.com/feos-org/feos/pull/323)
Expand Down
32 changes: 13 additions & 19 deletions crates/feos-core/src/ad/mod.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use crate::DensityInitialization::Liquid;
use crate::density_iteration::density_iteration;
use crate::{FeosResult, PhaseEquilibrium, ReferenceSystem, Residual};
use crate::{Composition, FeosResult, PhaseEquilibrium, ReferenceSystem, Residual};
use nalgebra::{Const, SVector, U1, U2};
#[cfg(feature = "rayon")]
use ndarray::{Array1, Array2, ArrayView2, Zip};
Expand Down Expand Up @@ -215,20 +215,21 @@ pub trait PropertiesAD {
)
}

fn bubble_point_pressure<const P: usize>(
fn bubble_point_pressure<const P: usize, X: Composition<f64, U2>>(
&self,
temperature: Temperature,
pressure: Option<Pressure>,
liquid_molefracs: SVector<f64, 2>,
liquid_molefracs: X,
) -> FeosResult<Pressure<Gradient<P>>>
where
Self: Residual<U2, Gradient<P>>,
{
let eos_f64 = self.re();
let (liquid_molefracs, _) = liquid_molefracs.into_molefracs(&eos_f64)?;
let vle = PhaseEquilibrium::bubble_point(
&eos_f64,
temperature,
&liquid_molefracs,
liquid_molefracs,
pressure,
None,
Default::default(),
Expand Down Expand Up @@ -265,20 +266,21 @@ pub trait PropertiesAD {
Ok(Pressure::from_reduced(p))
}

fn dew_point_pressure<const P: usize>(
fn dew_point_pressure<const P: usize, X: Composition<f64, U2>>(
&self,
temperature: Temperature,
pressure: Option<Pressure>,
vapor_molefracs: SVector<f64, 2>,
vapor_molefracs: X,
) -> FeosResult<Pressure<Gradient<P>>>
where
Self: Residual<U2, Gradient<P>>,
{
let eos_f64 = self.re();
let (vapor_molefracs, _) = vapor_molefracs.into_molefracs(&eos_f64)?;
let vle = PhaseEquilibrium::dew_point(
&eos_f64,
temperature,
&vapor_molefracs,
vapor_molefracs,
pressure,
None,
Default::default(),
Expand Down Expand Up @@ -329,12 +331,8 @@ pub trait PropertiesAD {
parameters,
input,
|eos: &Self::Lifted<Gradient<P>>, inp| {
eos.bubble_point_pressure(
inp[0] * KELVIN,
Some(inp[2] * PASCAL),
SVector::from([inp[1], 1.0 - inp[1]]),
)
.map(|p| p.convert_into(PASCAL))
eos.bubble_point_pressure(inp[0] * KELVIN, Some(inp[2] * PASCAL), inp[1])
.map(|p| p.convert_into(PASCAL))
},
)
}
Expand All @@ -353,12 +351,8 @@ pub trait PropertiesAD {
parameters,
input,
|eos: &Self::Lifted<Gradient<P>>, inp| {
eos.dew_point_pressure(
inp[0] * KELVIN,
Some(inp[2] * PASCAL),
SVector::from([inp[1], 1.0 - inp[1]]),
)
.map(|p| p.convert_into(PASCAL))
eos.dew_point_pressure(inp[0] * KELVIN, Some(inp[2] * PASCAL), inp[1])
.map(|p| p.convert_into(PASCAL))
},
)
}
Expand Down
4 changes: 4 additions & 0 deletions crates/feos-core/src/errors.rs
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ pub enum FeosError {
InvalidState(String, String, f64),
#[error("Undetermined state: {0}")]
UndeterminedState(String),
#[error(
"Extensive properties can only be evaluated for states that are initialized with extensive properties."
)]
IntensiveState,
#[error("System is supercritical.")]
SuperCritical,
#[error("No phase split according to stability analysis.")]
Expand Down
22 changes: 11 additions & 11 deletions crates/feos-core/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -299,8 +299,8 @@ mod tests {

// residual properties
assert_relative_eq!(
s.helmholtz_energy(Contributions::Residual),
sr.residual_helmholtz_energy(),
s.helmholtz_energy(Contributions::Residual)?,
sr.residual_helmholtz_energy()?,
max_relative = 1e-15
);
assert_relative_eq!(
Expand All @@ -309,8 +309,8 @@ mod tests {
max_relative = 1e-15
);
assert_relative_eq!(
s.entropy(Contributions::Residual),
sr.residual_entropy(),
s.entropy(Contributions::Residual)?,
sr.residual_entropy()?,
max_relative = 1e-15
);
assert_relative_eq!(
Expand All @@ -319,8 +319,8 @@ mod tests {
max_relative = 1e-15
);
assert_relative_eq!(
s.enthalpy(Contributions::Residual),
sr.residual_enthalpy(),
s.enthalpy(Contributions::Residual)?,
sr.residual_enthalpy()?,
max_relative = 1e-15
);
assert_relative_eq!(
Expand All @@ -329,8 +329,8 @@ mod tests {
max_relative = 1e-15
);
assert_relative_eq!(
s.internal_energy(Contributions::Residual),
sr.residual_internal_energy(),
s.internal_energy(Contributions::Residual)?,
sr.residual_internal_energy()?,
max_relative = 1e-15
);
assert_relative_eq!(
Expand All @@ -339,12 +339,12 @@ mod tests {
max_relative = 1e-15
);
assert_relative_eq!(
s.gibbs_energy(Contributions::Residual)
- s.total_moles()
s.gibbs_energy(Contributions::Residual)?
- s.total_moles()?
* RGAS
* s.temperature
* s.compressibility(Contributions::Total).ln(),
sr.residual_gibbs_energy(),
sr.residual_gibbs_energy()?,
max_relative = 1e-15
);
assert_relative_eq!(
Expand Down
63 changes: 36 additions & 27 deletions crates/feos-core/src/phase_equilibria/bubble_dew.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use crate::state::{
Contributions,
DensityInitialization::{InitialDensity, Liquid, Vapor},
};
use crate::{ReferenceSystem, Residual, SolverOptions, State, Verbosity};
use crate::{Composition, ReferenceSystem, Residual, SolverOptions, State, Verbosity};
use nalgebra::allocator::Allocator;
use nalgebra::{DMatrix, DVector, DefaultAllocator, Dim, Dyn, OVector, U1};
#[cfg(feature = "ndarray")]
Expand Down Expand Up @@ -141,10 +141,10 @@ where
{
/// Calculate a phase equilibrium for a given temperature
/// or pressure and composition of the liquid phase.
pub fn bubble_point<TP: TemperatureOrPressure<D>>(
pub fn bubble_point<TP: TemperatureOrPressure<D>, X: Composition<D, N>>(
eos: &E,
temperature_or_pressure: TP,
liquid_molefracs: &OVector<D, N>,
liquid_molefracs: X,
tp_init: Option<TP::Other>,
vapor_molefracs: Option<&OVector<f64, N>>,
options: (SolverOptions, SolverOptions),
Expand All @@ -162,10 +162,10 @@ where

/// Calculate a phase equilibrium for a given temperature
/// or pressure and composition of the vapor phase.
pub fn dew_point<TP: TemperatureOrPressure<D>>(
pub fn dew_point<TP: TemperatureOrPressure<D>, X: Composition<D, N>>(
eos: &E,
temperature_or_pressure: TP,
vapor_molefracs: &OVector<D, N>,
vapor_molefracs: X,
tp_init: Option<TP::Other>,
liquid_molefracs: Option<&OVector<f64, N>>,
options: (SolverOptions, SolverOptions),
Expand All @@ -181,35 +181,43 @@ where
)
}

pub(super) fn bubble_dew_point<TP: TemperatureOrPressure<D>>(
pub(super) fn bubble_dew_point<TP: TemperatureOrPressure<D>, X: Composition<D, N>>(
eos: &E,
temperature_or_pressure: TP,
vapor_molefracs: &OVector<D, N>,
vapor_molefracs: X,
tp_init: Option<TP::Other>,
liquid_molefracs: Option<&OVector<f64, N>>,
bubble: bool,
options: (SolverOptions, SolverOptions),
) -> FeosResult<Self> {
let (temperature, pressure, iterate_p) =
temperature_or_pressure.temperature_pressure(tp_init);
Self::bubble_dew_point_tp(
eos,
temperature,
pressure,
vapor_molefracs,
liquid_molefracs,
bubble,
iterate_p,
options,
)
if eos.components() == 1 {
let mut vle = Self::pure(eos, temperature_or_pressure, None, options.1)?;
if bubble {
vle.phase_fractions = [D::from(0.0), D::from(1.0)];
}
Ok(vle)
} else {
let (temperature, pressure, iterate_p) =
temperature_or_pressure.temperature_pressure(tp_init);
Self::bubble_dew_point_tp(
eos,
temperature,
pressure,
vapor_molefracs,
liquid_molefracs,
bubble,
iterate_p,
options,
)
}
}

#[expect(clippy::too_many_arguments)]
fn bubble_dew_point_tp(
fn bubble_dew_point_tp<X: Composition<D, N>>(
eos: &E,
temperature: Option<Temperature<D>>,
pressure: Option<Pressure<D>>,
molefracs_spec: &OVector<D, N>,
composition: X,
molefracs_init: Option<&OVector<f64, N>>,
bubble: bool,
iterate_p: bool,
Expand All @@ -218,6 +226,7 @@ where
let eos_re = eos.re();
let mut temperature_re = temperature.map(|t| t.re());
let mut pressure_re = pressure.map(|p| p.re());
let (molefracs_spec, total_moles) = composition.into_molefracs(eos)?;
let molefracs_spec_re = molefracs_spec.map(|x| x.re());
let (v1, rho2) = if iterate_p {
// temperature is specified
Expand Down Expand Up @@ -315,7 +324,7 @@ where
Self::newton_step_t(
eos,
t,
molefracs_spec,
&molefracs_spec,
&mut p,
&mut molar_volume,
&mut rho2,
Expand All @@ -325,7 +334,7 @@ where
Self::newton_step_p(
eos,
&mut t,
molefracs_spec,
&molefracs_spec,
p,
&mut molar_volume,
&mut rho2,
Expand All @@ -348,11 +357,11 @@ where
x2,
)?;

Ok(PhaseEquilibrium(if bubble {
[state2, state1]
Ok(if bubble {
PhaseEquilibrium::with_vapor_phase_fraction(state2, state1, D::from(0.0), total_moles)
} else {
[state1, state2]
}))
PhaseEquilibrium::with_vapor_phase_fraction(state1, state2, D::from(1.0), total_moles)
})
}

fn newton_step_t(
Expand Down
Loading
Loading