Skip to content

Integrated impl_cubics features into main #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JelleLagerweij wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Integrated impl_cubics features into main #282

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
694b319
implemented dumb test and required imports mod cubic.rs
JelleLagerweij May 16, 2025
bb3241e
cubic parameters implemented and refactored
JelleLagerweij May 16, 2025
c7f6a8a
question posted to issue
JelleLagerweij May 16, 2025
1ed069f
added serde feature to ndarray to avoid compilation error
JelleLagerweij May 17, 2025
afc6bb2
replaced last ParameterError with correct FeosError
JelleLagerweij May 17, 2025
f5c5f1c
Update test.yml
JelleLagerweij May 17, 2025
ec59539
resctrutured imports a bit
JelleLagerweij May 18, 2025
e88a4a2
Merge branch 'main' of github.com:JelleLagerweij/feos_cubics
JelleLagerweij May 18, 2025
8b96c6f
removed unnescecarry parts of the pull requests (.vscode file and uns…
JelleLagerweij May 20, 2025
f39634b
removed unescecarry file
JelleLagerweij May 20, 2025
6dc3a7f
Added additional testing to investigate why the implemented cubic eos…
JelleLagerweij Jun 2, 2025
a424fbf
WIP: local changes before merging upstream
JelleLagerweij Jul 6, 2025
07bf023
merged with origional upstream and solved differences
JelleLagerweij Jul 6, 2025
962aef6
attempting to figure out update in parameter(s)
JelleLagerweij Jul 6, 2025
8c9c176
some struggle with the new parameters implementation
JelleLagerweij Jul 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update test.yml 
also auto test cubic module
  • Loading branch information
@JelleLagerweij
JelleLagerweij authored May 17, 2025
commit f5c5f1c97e7ef7902310d3dc035c956a67b7873a
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
strategy:
fail-fast: false
matrix:
model: [pcsaft, epcsaft, gc_pcsaft, pets, uvtheory, saftvrqmie, saftvrmie]
model: [pcsaft, epcsaft, gc_pcsaft, pets, uvtheory, saftvrqmie, saftvrmie, cubic]

steps:
- uses: actions/checkout@v4
Expand Down