Optional binary records and new parameter constructor#169
Merged
prehner merged 2 commits intobinary_associationfrom Jul 10, 2023
Merged
Optional binary records and new parameter constructor#169prehner merged 2 commits intobinary_associationfrom
prehner merged 2 commits intobinary_associationfrom
Conversation
5d77ba6 to
866ff9b
Compare
g-bauer
approved these changes
Jul 10, 2023
prehner
added a commit
that referenced
this pull request
Jul 10, 2023
* Implement binary association parameters * Optional binary records and new parameter constructor (#169)
prehner
added a commit
that referenced
this pull request
Jul 14, 2023
* Implement binary association parameters * Optional binary records and new parameter constructor (#169)
prehner
added a commit
that referenced
this pull request
Jul 14, 2023
* Implement binary association parameters * Optional binary records and new parameter constructor (#169)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR comprises of two changes:
binary_recordsinParameter::from_recordsis made optional. This removes some boilerplate from models that do not use binary interaction parameters at all (ideal gas models and pure component models). If the models have a GC method, they still need a custom struct for binary records to implement all necessary traits.Parameter::from_model_recordsis added that internally creates thePureRecords using defaults for molarweight and identifier, and does not use binary records. This is necessary, because at the moment, it is not possible to createJobackParametersfrom records in Python, since there is no appropriatePureRecordaround.