Fixes for the bubble and dew point calculations#166
Merged
prehner merged 1 commit intodevelopmentfrom Jul 7, 2023
Merged
Conversation
g-bauer
approved these changes
Jul 7, 2023
prehner
added a commit
that referenced
this pull request
Jul 14, 2023
prehner
added a commit
that referenced
this pull request
Jul 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the assignment of the liquid and vapor phases which helps tremendously for the calculation of supercritical phase diagrams.
The change with respect to the inital pressure is done because for high-pressure VLEs FeOs/PC-SAFT appear to find unphysical solutions at very low pressures. In this case, it is preferred to just not find any solution at all rather than the unphysical one.