Merged
Conversation
This was
linked to
issues
Apr 3, 2023
Closed
g-bauer
reviewed
Apr 6, 2023
g-bauer
approved these changes
Apr 14, 2023
prehner
added a commit
that referenced
this pull request
Jul 14, 2023
* More generic association models * Rewrite association contribution to be more generic * Michael L. Michelsen to the rescue once again * Add hard-sphere theory guide * update parameter files * cleanup * add changelog
prehner
added a commit
that referenced
this pull request
Jul 14, 2023
* More generic association models * Rewrite association contribution to be more generic * Michael L. Michelsen to the rescue once again * Add hard-sphere theory guide * update parameter files * cleanup * add changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of the association term, assumes certain association schemes depending on the provided parameters. In this PR the association term is written in a more generic way. This paves the way to allowing multiple association sites per molecule and also association between self-associating and non self-associating molecules.
For details check out the new entry in the theory guide.