Fix the sign of vector weighted densities in cartesian and cylindrical geometry#120
Merged
Fix the sign of vector weighted densities in cartesian and cylindrical geometry#120
Conversation
Contributor
Author
|
At the moment the calculation is excruciatingly hard to comprehend due to some shortcuts/simplifications that were applied without further explanations. It should be explained in the theory guide. |
g-bauer
approved these changes
Jan 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change vector weighted densities will have the correct signs in all geometries.
While this is an important validation of the correctness of the transforms in general, the sign of vector weighted densities had no effect on results as they always appear in dot products in the calculation of Helmholtz energies, which cancel out their sign.
Shout out to @RolfStierle and @oivindwi.