Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows code like
From the resulting
PhaseDiagramobject, the properties can then be obtained without having to write loops.Similar to that
StateVecis exposed in Python and gets a corresponding constructor, that can be used like this:Other smaller changes:
PhaseDiagram"inherits" the const generic that indicates the number of phases fromPhaseEquilibrium. It was a somewhat unnecessary limitation, that could make future additions breaking changes. In PythonPhaseDiagramis still fixed to 2 phases and there is currently no analog toThreePhaseEquilibriumas it isn't needed.StateVec::molesis added as an additional getter. A small inconvenience: At this point it is not possible to indexSIArray2s in Python.