Skip to content

[Snyk] Security upgrade node-pre-gyp from 0.6.39 to 0.17.0 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fengmk2 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Security upgrade node-pre-gyp from 0.6.39 to 0.17.0 #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
},
"dependencies": {
"nan": "~2.1.0",
"node-pre-gyp": "~0.6.14"
"node-pre-gyp": "~0.17.0"

@gemini-code-assist gemini-code-assist Bot Jan 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This upgrade to node-pre-gyp@~0.17.0 introduces a breaking change by dropping support for older Node.js versions.

  • New Requirement: node-pre-gyp@~0.17.0 requires Node.js >= 12.
  • Old Support: The previous version ~0.6.14 supported Node.js >= 0.8.
  • Project Compatibility: This package version (3.1.1) uses nan@~2.1.0, which implies support for Node.js v4 and v5.

Merging this PR will break the build for anyone using this package on Node.js versions older than 12.

The security vulnerability is fixed in node-pre-gyp >= 0.11.0, which itself requires Node.js >= 6. This means any fix will be a breaking change for users on Node.js v4/v5. This change should likely be part of a new major version release.

},
"bundledDependencies": [
"node-pre-gyp"
Expand Down