Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
},
"dependencies": {
"nan": "~2.1.0",
"node-pre-gyp": "~0.6.14"
"node-pre-gyp": "~0.17.0"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This is a major version upgrade for node-pre-gyp, from 0.6.x to 0.17.x. Such a large jump across multiple major versions likely introduces breaking changes that could break the build process for this package.

For example, node-pre-gyp's configuration via the binary property in package.json or its command-line arguments used in scripts may have changed.

This PR should be expanded to include any necessary compatibility changes in package.json or other build-related files to ensure the native addon can still be built and packaged correctly. Without these accompanying changes, the build is likely to fail for developers and consumers of this package, preventing them from installing it.

},
"bundledDependencies": [
"node-pre-gyp"
Expand Down