Skip to content

[CI] Make artifact download script robust to failures #6716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mihaibudiu wants to merge 1 commit into from
+20 −12
Open

[CI] Make artifact download script robust to failures #6716

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 20 additions & 12 deletions .github/actions/download-artifact-retry/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ runs:

api="https://api.github.com/repos/${REPOSITORY}"

artifact_json=$(curl -fsSL \
artifact_json=$(curl -fsSL --retry 3 --retry-connrefused --retry-delay 2 \
-H "Authorization: Bearer ${GH_TOKEN}" \
-H "Accept: application/vnd.github+json" \
"${api}/actions/runs/${RUN_ID}/artifacts?name=${ARTIFACT_NAME}&per_page=100" \
Expand All @@ -75,25 +75,33 @@ runs:
while true; do
echo "==> Download attempt ${attempt}/${MAX_ATTEMPTS}: ${ARTIFACT_NAME} (expecting ${expected_size} bytes)"

# Capture curl's status instead of letting set -e abort the step:
# curl only auto-retries errors it deems transient, so mid-transfer
# failures (e.g. exit 56, connection reset) must reach this loop.
curl_status=0
curl -fsSL --retry 3 --retry-connrefused --retry-delay 2 \
-H "Authorization: Bearer ${GH_TOKEN}" \
-H "Accept: application/vnd.github+json" \
-o "$zip_path" \
"${api}/actions/artifacts/${artifact_id}/zip"
"${api}/actions/artifacts/${artifact_id}/zip" || curl_status=$?

actual_size=$(wc -c <"$zip_path" | tr -d ' ')

if [ "$actual_size" != "$expected_size" ]; then
echo "::warning::Size mismatch on attempt ${attempt} for '${ARTIFACT_NAME}' (expected ${expected_size} bytes, got ${actual_size}) — download was truncated"
if [ "$curl_status" -ne 0 ]; then
echo "::warning::Download failed on attempt ${attempt} for '${ARTIFACT_NAME}' (curl exit code ${curl_status})"
else
actual_digest=$(sha256sum "$zip_path" | awk '{print $1}')
actual_size=$(wc -c <"$zip_path" | tr -d ' ')

if [ "$actual_digest" = "$expected_digest" ]; then
echo "==> Checksum verified (sha256:${actual_digest})"
break
fi
if [ "$actual_size" != "$expected_size" ]; then
echo "::warning::Size mismatch on attempt ${attempt} for '${ARTIFACT_NAME}' (expected ${expected_size} bytes, got ${actual_size}) — download was truncated"
else
actual_digest=$(sha256sum "$zip_path" | awk '{print $1}')

echo "::warning::Checksum mismatch on attempt ${attempt} for '${ARTIFACT_NAME}' (expected sha256:${expected_digest}, got sha256:${actual_digest}) — download was corrupted in transit"
if [ "$actual_digest" = "$expected_digest" ]; then
echo "==> Checksum verified (sha256:${actual_digest})"
break
fi

echo "::warning::Checksum mismatch on attempt ${attempt} for '${ARTIFACT_NAME}' (expected sha256:${expected_digest}, got sha256:${actual_digest}) — download was corrupted in transit"
fi
fi

if [ "$attempt" -ge "$MAX_ATTEMPTS" ]; then
Expand Down