[SQL] Remove unneeded http5 dependencies from maven file pom.xml#6708
[SQL] Remove unneeded http5 dependencies from maven file pom.xml#6708mihaibudiu wants to merge 1 commit into
Conversation
mythical-fred
left a comment
There was a problem hiding this comment.
One inline nit on a typo. Otherwise LGTM — jackson 2.22.1 is the latest patch, exclusions are conservative.
| <artifactId>httpclient5</artifactId> | ||
| </exclusion> | ||
| <exclusion> | ||
| <groupId>org.apache.httpclient5</groupId> |
There was a problem hiding this comment.
Typo in the groupId: org.apache.httpclient5 isn't a real Maven groupId. Verified against Maven Central — httpcore5-h2 lives under org.apache.httpcomponents.core5 (same groupId as the httpcore5 exclusion right below). Maven silently no-ops exclusions whose group/artifact don't match, so this line has no effect and the transitive httpcore5-h2 from avatica-core would still be pulled in.
Suggested:
<exclusion>
<groupId>org.apache.httpcomponents.core5</groupId>
<artifactId>httpcore5-h2</artifactId>
</exclusion>Since the identical exclusion block appears in the avatica-core dependency further down (same three exclusions, same typo), that one is broken today as well and would be worth fixing at the same time. mvn dependency:tree -Dverbose will show whether httpcore5-h2 is actually present.
There was a problem hiding this comment.
and yet, none of the http dependencies is shown by mvn dependency:tree
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Calcite depends on Avatica which pulls in httpclient. This should never be used by the SQL compiler, so I just removed these dependencies.