Handle Kafka tombstone messages#6707
Open
xiasongh wants to merge 1 commit into
Open
Conversation
Contributor
|
copilot claims a slightly different terminology: tombstones null values. But you seem to imply they have null keys too. |
Contributor
Author
copilot is correct, tombstones are kafka messages with non-null keys and null values. i should specify empty value rather than payload |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kafka topics can have "tombstone" messages, which are messages with an empty payload. These are valid messages, but will fail and emit an error when attempting to parse as avro.
Technically the current behaviour is still correct, the tombstone message gets skipped successfully, but can just handle properly.
Describe Manual Test Plan
Setup Feldera and Redpanda, send a tombstone message, verify no error logs
Checklist
Breaking Changes?
Mark if you think the answer is yes for any of these components:
Describe Incompatible Changes