[adapters] Make /stats query parameters public.#6704
Open
blp wants to merge 1 commit into
Open
Conversation
This makes it easier for other code to use these parameters. Signed-off-by: Ben Pfaff <blp@feldera.com>
blp
force-pushed
the
publish-stats-params
branch
from
July 22, 2026 23:48
8a76280 to
c17d53d
Compare
mythical-fred
approved these changes
Jul 23, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
Straightforward hoist of StatsParams from crates/adapters/src/server.rs into feldera-types::query_params next to the other endpoint params (ActivateParams, ApproveParameters, MetricsParameters, SamplyProfileParams). Doc comment preserved verbatim, #[serde(default)] preserved, field made pub, and Serialize added — the other public param structs in that module all derive Serialize too, so this is consistent.
The support-bundle collector wanting to construct these outside server.rs is exactly the shape of refactor that belongs in feldera-types. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easier for other code to use these parameters.