Continue Avro validation after missing nullable fields#6698
Draft
xiasongh wants to merge 1 commit into
Draft
Conversation
mihaibudiu
approved these changes
Jul 22, 2026
Contributor
|
Why is this a draft? Can we merge it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
validate_struct_schemareturned success for the entire record when it encountered one missing nullable column. This skipped validation of every subsequent column, allowing missing required or incompatible columns to pass startup validation and fail later while parsing data.Impact
Missing nullable columns remain supported for schema evolution, while all other declared SQL columns are still checked for compatibility.
Validation
cargo test -p dbsp_adapters format::avro:: --lib(46 passed on current upstream main)cargo test -p dbsp_adapters missing_nullable_field_does_not_stop_validation --lib(passed on the published fork branch)cargo fmt --all -- --check