[web-console] Fix incorrect background when scrolling Performance tab#6684
Open
Karakatiza666 wants to merge 1 commit into
Open
[web-console] Fix incorrect background when scrolling Performance tab#6684Karakatiza666 wants to merge 1 commit into
Karakatiza666 wants to merge 1 commit into
Conversation
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
mihaibudiu
approved these changes
Jul 20, 2026
mythical-fred
approved these changes
Jul 20, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
APPROVE.
Clean fix. Two issues rolled into one PR, both driven by wide content (the connector table) in flex panes:
InlineDrawer.svelte: addingmin-w-0to both<Pane>wrappers is the right counter tooverflow: visiblere-enabling the flex defaultmin-width: auto. The two new tests inInlineDrawer.svelte.spec.tsnail both failure modes — the main pane stretching past its container, and the drawer pane being squeezed to zero when the main content refuses to shrink. UsingcreateRawSnippetwithwhite-space: nowrapand a fat repeated string is a nice reproducible way to force min-content width without a fixture.TabPerformance.svelte:h-fullon the scrollable column is what makes the background actually track the scroll (the container was collapsing to intrinsic content height, so the striped/gradient background didn't fill the scrolled region). Small but load-bearing.
The wrap-tightening of the WarningBanner string is unrelated to the fix; harmless.
Nits, all non-blocking:
- Commit subject has "bi-directinal" → "bi-directional" on the earlier PR, and here the body says "Testing: manual, added regression test" (singular) — you actually added two. Cosmetic.
- The second test asserts
> 300for a40% of 1000pxsplit. That's a wide tolerance (accepts 301..1000). If a future regression makes the drawer eat the whole width, this test would still pass. ConsidertoBeGreaterThan(350)andtoBeLessThan(500)to bracket the expected split.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 21, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing: manual, added regression test
Fix #6675
Screencast.From.2026-07-21.00-45-35.webm