Skip to content

[web-console] Fix incorrect background when scrolling Performance tab#6684

Open
Karakatiza666 wants to merge 1 commit into
mainfrom
issue6675
Open

[web-console] Fix incorrect background when scrolling Performance tab#6684
Karakatiza666 wants to merge 1 commit into
mainfrom
issue6675

Conversation

@Karakatiza666

Copy link
Copy Markdown
Contributor

Testing: manual, added regression test

Fix #6675

Screencast.From.2026-07-21.00-45-35.webm

@Karakatiza666
Karakatiza666 requested a review from mihaibudiu July 20, 2026 20:47
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>

@mythical-fred mythical-fred left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE.

Clean fix. Two issues rolled into one PR, both driven by wide content (the connector table) in flex panes:

  • InlineDrawer.svelte: adding min-w-0 to both <Pane> wrappers is the right counter to overflow: visible re-enabling the flex default min-width: auto. The two new tests in InlineDrawer.svelte.spec.ts nail both failure modes — the main pane stretching past its container, and the drawer pane being squeezed to zero when the main content refuses to shrink. Using createRawSnippet with white-space: nowrap and a fat repeated string is a nice reproducible way to force min-content width without a fixture.
  • TabPerformance.svelte: h-full on the scrollable column is what makes the background actually track the scroll (the container was collapsing to intrinsic content height, so the striped/gradient background didn't fill the scrolled region). Small but load-bearing.

The wrap-tightening of the WarningBanner string is unrelated to the fix; harmless.

Nits, all non-blocking:

  • Commit subject has "bi-directinal" → "bi-directional" on the earlier PR, and here the body says "Testing: manual, added regression test" (singular) — you actually added two. Cosmetic.
  • The second test asserts > 300 for a 40% of 1000px split. That's a wide tolerance (accepts 301..1000). If a future regression makes the drawer eat the whole width, this test would still pass. Consider toBeGreaterThan(350) and toBeLessThan(500) to bracket the expected split.

@Karakatiza666
Karakatiza666 added this pull request to the merge queue Jul 21, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 21, 2026
@Karakatiza666
Karakatiza666 added this pull request to the merge queue Jul 22, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[WebConsole] Connector table doesn't fit in the grey area in the Runtime tab.

3 participants