pipeline-manager: filter further forwarded pipeline streaming headers#6682
Open
snkas wants to merge 1 commit into
Open
pipeline-manager: filter further forwarded pipeline streaming headers#6682snkas wants to merge 1 commit into
snkas wants to merge 1 commit into
Conversation
The `authorization` header has already been handled by the API server, and thus does not need to be included in the headers sent to the pipeline. Signed-off-by: Simon Kassing <simon.kassing@feldera.com>
snkas
enabled auto-merge
July 20, 2026 13:28
mythical-fred
approved these changes
Jul 20, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
Sensible narrow fix. authorization gets validated by the API server before the runner ever calls into streaming_proxy, so forwarding it to the pipeline just leaks the bearer token one hop deeper without adding any check on the receiving side. Filter matches the existing casing-insensitive HeaderName == &str pattern used for connection/accept-encoding, so it correctly catches Authorization too. Comment placement is fine.
Optional (non-blocking): if we're building an allow-list mindset here, cookie and proxy-authorization are the other two "credential-ish" headers a caller could set that the pipeline has no business seeing. Worth considering in a follow-up, but scope for this PR is right.
APPROVE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
authorizationheader has already been handled by the API server, and thus does not need to be included in the headers sent to the pipeline.