[adapters] Regression in gather_output_to_host.#6647
Merged
Conversation
Switching to a streaming exchange in gather_output_to_host introduced a regression where the exchange was disabled on all but one host (the one that the stream is assigned to). As a result these hosts didn't collaborate in delivering outputs to the assigned host. Signed-off-by: Leonid Ryzhyk <ryzhyk@gmail.com>
mythical-fred
approved these changes
Jul 16, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
LGTM. Fix matches the described symptom and the existing multihost tests (test_pandas_struct/test_pandas_simple/test_url_encoding) are the regression net. Perf caveat is called out in the comment.
blp
approved these changes
Jul 16, 2026
Member
|
I filed #6649 so that the optimization suggested in the comment doesn't get lost so easily. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching to a streaming exchange in gather_output_to_host introduced a regression where the exchange was disabled on all but one host (the one that the stream is assigned to). As a result these hosts didn't collaborate in delivering outputs to the assigned host.
This bug caused several multihost tests to fail in CI (test_pandas_struct / test_pandas_simple / test_url_encoding). The tests are passing (at least locally) with this fix.
This fix does have a performance implication: views without connectors attached to them are still gathered on one host just to get discarded.