[adapters] Widen test HTTP client request timeout to avoid CI flakes#6628
Merged
Conversation
TestHttpSender relied on awc's 5s default request timeout, which is shorter than the test harness's own 20s async_wait/completion budgets. Under CI load, or a k8s CPU-quota freeze that stalls the in-process server past 5s, the client deadline fires and panics an otherwise healthy request (observed as test_silent_bootstrap failing with `Err(Timeout)` at test/http.rs). The /ingress POST is non-idempotent, so retrying on timeout could double-insert records; instead widen the client deadline to 120s and let the higher-level waits govern liveness. Signed-off-by: Leonid Ryzhyk <ryzhyk@gmail.com>
ryzhyk
enabled auto-merge
July 14, 2026 02:27
gz
approved these changes
Jul 14, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 14, 2026
mythical-fred
approved these changes
Jul 14, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
Sensible fix. awc's 5s default is genuinely shorter than the harness's 20s async_wait budget, and the /ingress POST is non-idempotent so bumping the client deadline rather than retrying is the right call. Commit message explains the why clearly (CPU-quota freeze, non-idempotent), which is exactly the shape a "just widen a timeout" change needs to justify itself. Signed-off, no AI trailers, one file, one const, one call site.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestHttpSender relied on awc's 5s default request timeout, which is shorter than the test harness's own 20s async_wait/completion budgets. Under CI load, or a k8s CPU-quota freeze that stalls the in-process server past 5s, the client deadline fires and panics an otherwise healthy request (observed as test_silent_bootstrap failing with
Err(Timeout)at test/http.rs).The /ingress POST is non-idempotent, so retrying on timeout could double-insert records; instead widen the client deadline to 120s and let the higher-level waits govern liveness.