[DBSP] Add a 'positive' operator, a variant of 'distinct'#6617
Merged
Conversation
ryzhyk
approved these changes
Jul 10, 2026
| /// │ 0, otherwise | ||
| /// └ | ||
| /// ┌ | ||
| /// │ 1, if w > 0 |
Contributor
There was a problem hiding this comment.
I guess this is no longer true?
Contributor
Author
There was a problem hiding this comment.
It is true, it says "e.g., for distinct".
| positive_test(true); | ||
| } | ||
|
|
||
| fn positive_test(transaction: bool) { |
Contributor
There was a problem hiding this comment.
Can we get claude build a proptest and/or test it more thoroughly for corner cases (i know there aren't many, but still)
Contributor
Author
There was a problem hiding this comment.
I have generated a more exhaustive test. I will merge this.
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
mihaibudiu
enabled auto-merge
July 10, 2026 23:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new DBSP operator which is just like DISTINCT, but keeps the positive weight unchanged (DISTINCT clamps any positive weight to 1). This is a much more efficient building block for implementing
EXCEPT ALL, I plan to use this implementation in solving #5483 instead of the currently open PR.Checklist