-
Notifications
You must be signed in to change notification settings - Fork 141
[manager] Set the memory limits from the local OS/container when they are not specified #6603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+188
−18
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| //! System introspection utilities. | ||
|
|
||
| /// True when this process runs inside a Kubernetes pod. | ||
| /// | ||
| /// Kubernetes injects `KUBERNETES_SERVICE_HOST` into every pod, and the | ||
| /// pipeline manager rejects user-supplied `KUBERNETES_*` variables in the | ||
| /// pipeline's `env` config. | ||
| pub fn running_in_kubernetes() -> bool { | ||
| std::env::var_os("KUBERNETES_SERVICE_HOST").is_some() | ||
| } | ||
|
|
||
| /// Returns the memory, in megabytes (MB), of the current system, or `None` | ||
| /// when the operating system does not report it. | ||
| /// | ||
| /// This is the min of the host's available memory and the cgroup budget | ||
| /// (what a container or Kubernetes pod memory limit sets). | ||
| pub fn total_memory_megabyte() -> Option<u64> { | ||
| let mut system = sysinfo::System::new(); | ||
| system.refresh_memory(); | ||
| let mut available = system.total_memory(); | ||
| if let Some(limits) = system.cgroup_limits() { | ||
| available = available.min(limits.total_memory); | ||
| } | ||
| let mb = available / 1_000_000; | ||
| // `sysinfo` reports 0 on platforms it does not support. | ||
| if mb > 0 { Some(mb) } else { None } | ||
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { | ||
| /// Guards the `sysinfo` call sequence (`cgroup_limits` panics when memory | ||
| /// was not refreshed first). | ||
| #[cfg(target_os = "linux")] | ||
| #[test] | ||
| fn reports_nonzero_memory() { | ||
| let mb = super::total_memory_megabyte().expect("Linux reports available memory"); | ||
| assert!(mb > 0, "available memory must be positive, got {mb} MB"); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you know the hosts are colocated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we are in the local_runner.rs file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, overlooked that. There should be a counterpart downstream PR as well for this to find out if it works as expected in non-local form factor.