Skip to content

[DOCS] Document limitations of UNNEST#6598

Merged
mihaibudiu merged 1 commit into
feldera:mainfrom
mihaibudiu:unnest-limits
Jul 7, 2026
Merged

[DOCS] Document limitations of UNNEST#6598
mihaibudiu merged 1 commit into
feldera:mainfrom
mihaibudiu:unnest-limits

Conversation

@mihaibudiu

Copy link
Copy Markdown
Contributor

Describe Manual Test Plan

Document the fact that we do not support LEFT JOIN UNNEST, the semantics is different.
We will add support in the future.
The documentation suggests a workaround.

Checklist

  • Unit tests added/updated
  • Documentation updated

Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
@mihaibudiu
mihaibudiu requested a review from anandbraman July 6, 2026 23:27
@mihaibudiu
mihaibudiu enabled auto-merge July 6, 2026 23:28

@mythical-fred mythical-fred left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc addition reads well and the workaround is genuinely useful. Two small nits, all non-blocking:

  • unsupported-operations.md line 76: stray comma — and \OUTER APPLY (...)` are not yet supported:` (no comma before "are").
  • The array.md workaround only covers the NULL case; empty arrays still drop rows under CROSS JOIN UNNEST. One extra sentence noting that would spare users a follow-up "why doesn't this work for []?". Not required.

The compiler change (throw UnimplementedException when JoinType != INNER in visitCorrelate) is what makes the doc claim true, and the paired issue2736b test locks it in — nice. Title says [DOCS] though; a reader scanning git log for compiler behavior changes would miss this. Worth a [SQL] or dual tag next time.

APPROVE.

@anandbraman anandbraman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarifications and compiler errors/warnings

@mihaibudiu
mihaibudiu added this pull request to the merge queue Jul 7, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 7, 2026
@mihaibudiu
mihaibudiu added this pull request to the merge queue Jul 7, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 7, 2026
@mihaibudiu
mihaibudiu added this pull request to the merge queue Jul 7, 2026
Merged via the queue into feldera:main with commit 1125fc5 Jul 7, 2026
1 check passed
@mihaibudiu
mihaibudiu deleted the unnest-limits branch July 7, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants