[DOCS] Document limitations of UNNEST#6598
Merged
Merged
Conversation
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
mihaibudiu
enabled auto-merge
July 6, 2026 23:28
mythical-fred
approved these changes
Jul 7, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
Doc addition reads well and the workaround is genuinely useful. Two small nits, all non-blocking:
unsupported-operations.mdline 76: stray comma —and \OUTER APPLY (...)` are not yet supported:` (no comma before "are").- The
array.mdworkaround only covers theNULLcase; empty arrays still drop rows underCROSS JOIN UNNEST. One extra sentence noting that would spare users a follow-up "why doesn't this work for[]?". Not required.
The compiler change (throw UnimplementedException when JoinType != INNER in visitCorrelate) is what makes the doc claim true, and the paired issue2736b test locks it in — nice. Title says [DOCS] though; a reader scanning git log for compiler behavior changes would miss this. Worth a [SQL] or dual tag next time.
APPROVE.
anandbraman
approved these changes
Jul 7, 2026
anandbraman
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the clarifications and compiler errors/warnings
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 7, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Manual Test Plan
Document the fact that we do not support
LEFT JOIN UNNEST, the semantics is different.We will add support in the future.
The documentation suggests a workaround.
Checklist