Fix incorrect column order in the pipelines table#6592
Conversation
mythical-fred
left a comment
There was a problem hiding this comment.
The new deletePipelineBlockedReason returns strings with a trailing period, but several assertions in the new spec compare against strings without one — those tests cannot pass as written. See inline. Otherwise the column-order fix + regression test and the split-out delete-blocked helper are a nice improvement.
45194f3 to
acdd53f
Compare
mythical-fred
left a comment
There was a problem hiding this comment.
Blocker resolved — the helper is now deletePipelineDisabledReason and every asserted string in the new spec ends in a period, matching what the helper returns. The transitional-states loop, the error-state loop, and the mid-clear case all line up. Nice cleanup overall.
Approving.
|
|
||
| export const duplicatePipelineTooltip = | ||
| 'Pipeline storage and state are not duplicated. The new pipeline starts fresh.' | ||
| 'The connectors are preserved. Pipeline storage and state are not copied - the new pipeline starts fresh.' |
There was a problem hiding this comment.
not entirely sure what "preserved" means. Does it mean the code is the same, or that the state of the storage systems behind the connectors is also somehow preserved?
| // text is whitespace-collapsed so responsive label variants (e.g. the short and | ||
| // long "Runtime errors" spans, both present in the DOM) compare deterministically. | ||
| const columnHeaders = () => | ||
| Array.from(document.querySelectorAll('thead th')).map((th) => |
There was a problem hiding this comment.
this works only if there's a single table in the whole document
There was a problem hiding this comment.
At the time of this test there is, but I'll narrow down the selection just to be safe
Fix tooltips for 'Duplicate' and 'Delete' actions Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
|
@Karakatiza666 , why aren't we merging this? This fixes some pretty serious WebConsole issues. |
Fix tooltips for 'Duplicate' and 'Delete' actions
Testing: manual, added regression test for column order, and unit test for determining the correct tooltip for the "Delete" action
Fix #6604