[connectors] Tolerate transient Kafka errors in FT input tests#6588
Merged
Conversation
Transient librdkafka connectivity blips ("AllBrokersDown", "N/M brokers
are down") are reported to the consumer as non-fatal errors, and the
connector recovers on its own. DummyInputConsumer recorded every such
error in the strict call sequence that expect() checks, so a blip
anywhere in a test failed it, e.g.:
thread 'transport::kafka::ft::test::multiple_input' panicked at
crates/adapters/src/transport/kafka/ft/test.rs:463:22:
assertion `left == right` failed
left: [Extended { num_records: 90, ... }]
right: [Error(false)]
Record only fatal errors. No test expects ConsumerCall::Error, so no
expectation changes.
Signed-off-by: Leonid Ryzhyk <ryzhyk@gmail.com>
mythical-fred
approved these changes
Jul 3, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
Clean fix. Non-fatal Kafka errors are transient and cosmetic from the test's perspective — swallowing them from the call sequence is the right move since the connector's own recovery path is what actually needs to be exercised, and the Error(true) case is still recorded so real fatal errors don't get masked. LGTM.
mihaibudiu
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transient librdkafka connectivity blips ("AllBrokersDown", "N/M brokers are down") are reported to the consumer as non-fatal errors, and the connector recovers on its own. DummyInputConsumer recorded every such error in the strict call sequence that expect() checks, so a blip anywhere in a test failed it, e.g.:
thread 'transport::kafka::ft::test::multiple_input' panicked at
crates/adapters/src/transport/kafka/ft/test.rs:463:22:
assertion
left == rightfailedleft: [Extended { num_records: 90, ... }]
right: [Error(false)]
Record only fatal errors. No test expects ConsumerCall::Error, so no expectation changes.