Skip to content

[adapters] Tolerate transient Kafka errors in FT input tests #6586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ryzhyk wants to merge 1 commit into from
Closed

[adapters] Tolerate transient Kafka errors in FT input tests #6586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion crates/adapters/src/transport/kafka/ft/test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,7 +757,12 @@ impl InputConsumer for DummyInputConsumer {

fn error(&self, fatal: bool, error: AnyError, _tag: Option<&'static str>) {
info!("error: {error}");
self.called(ConsumerCall::Error(fatal));
// Record only fatal errors. Non-fatal errors, such as a momentary
// broker disconnection, can arrive at any time, and recording them
// would break the strict call sequence that `expect()` checks.
if fatal {
self.called(ConsumerCall::Error(fatal));
}
}

fn request_step(&self) {}
Expand Down