[adapters] Increase suspend_barrier test timeout to 100s#6584
Merged
Conversation
Increasing a timeout is usually not the right fix, but I was able to reproduce locally that under heavy load commit time increases from 1s to 6s. It's not impossible that it reaches 10s on the CI machine. Signed-off-by: Leonid Ryzhyk <ryzhyk@gmail.com>
ryzhyk
enabled auto-merge
July 2, 2026 22:34
mihaibudiu
approved these changes
Jul 2, 2026
mythical-fred
approved these changes
Jul 3, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
Fine as a CI stabilization measure — 100s is loose enough that a slow CI machine hitting the 6s commit path won't flake, and the test path exercised is unchanged. If commit times keep drifting upward under heavy load, though, the real fix is worth chasing (bounded commit latency is a nicer invariant than a fat timeout).
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 3, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increasing a timeout is usually not the right fix, but I was able to reproduce locally that under heavy load commit time increases from 1s to 6s. It's not impossible that it reaches 10s on the CI machine.