Skip to content

[adapters] Increase suspend_barrier test timeout to 100s#6584

Merged
ryzhyk merged 1 commit into
mainfrom
bump-suspend-barrier-test-timeout
Jul 3, 2026
Merged

[adapters] Increase suspend_barrier test timeout to 100s#6584
ryzhyk merged 1 commit into
mainfrom
bump-suspend-barrier-test-timeout

Conversation

@ryzhyk

@ryzhyk ryzhyk commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Increasing a timeout is usually not the right fix, but I was able to reproduce locally that under heavy load commit time increases from 1s to 6s. It's not impossible that it reaches 10s on the CI machine.

Increasing a timeout is usually not the right fix, but I was able to reproduce
locally that under heavy load commit time increases from 1s to 6s. It's not
impossible that it reaches 10s on the CI machine.

Signed-off-by: Leonid Ryzhyk <ryzhyk@gmail.com>
@ryzhyk
ryzhyk requested a review from mihaibudiu July 2, 2026 22:34
@ryzhyk ryzhyk added ft Fault tolerant, distributed, and scale-out implementation connectors Issues related to the adapters/connectors crate labels Jul 2, 2026
@ryzhyk
ryzhyk enabled auto-merge July 2, 2026 22:34
@ryzhyk
ryzhyk added this pull request to the merge queue Jul 2, 2026

@mythical-fred mythical-fred left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine as a CI stabilization measure — 100s is loose enough that a slow CI machine hitting the 6s commit path won't flake, and the test path exercised is unchanged. If commit times keep drifting upward under heavy load, though, the real fix is worth chasing (bounded commit latency is a nicer invariant than a fat timeout).

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 3, 2026
@ryzhyk
ryzhyk added this pull request to the merge queue Jul 3, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 3, 2026
@ryzhyk
ryzhyk added this pull request to the merge queue Jul 3, 2026
Merged via the queue into main with commit 2817598 Jul 3, 2026
1 check passed
@ryzhyk
ryzhyk deleted the bump-suspend-barrier-test-timeout branch July 3, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

connectors Issues related to the adapters/connectors crate ft Fault tolerant, distributed, and scale-out implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants