[py] Move test_output_buffer_size_limit.py to runtime tests#6574
Merged
Conversation
This test mostly cover the handling of output buffers by the runtime, so it belongs in runtime tests. Signed-off-by: Leonid Ryzhyk <ryzhyk@gmail.com>
ryzhyk
enabled auto-merge
July 2, 2026 04:08
mihaibudiu
approved these changes
Jul 2, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 2, 2026
mythical-fred
approved these changes
Jul 2, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
Clean move: the runtime/ variants of these tests don't use gen_pipeline_name (the pipeline_name fixture from tests/conftest.py handles uniqueness) and deliberately skip try/finally + force-stop so the persistent runtime instance is left inspectable on failure — matches sibling test_null_output.py, test_transactions.py, etc. Comment on line ~95 already documents the intentional no-stop behavior. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test mostly cover the handling of output buffers by the runtime, so it belongs in runtime tests.