Skip to content

[profiler] merges.avg_step_time may be undefined #6570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mihaibudiu merged 1 commit into from
Jul 2, 2026
Merged

[profiler] merges.avg_step_time may be undefined #6570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions js-packages/profiler-lib/src/profile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -998,16 +998,21 @@ export class Measurement {
}
case "merges": {
let s = metric.value as MergesMetricValue;
let avg_step_time = TimeValue.fromDurationMetric(s.avg_step_time);
let avg_step_time = undefined;
let result = [];
if (s.avg_step_time !== undefined) {
avg_step_time = TimeValue.fromDurationMetric(s.avg_step_time);
result.push(new Measurement(metric_id + ".avg_step_time", Option.some(avg_step_time)));
}
let batches = CountValue.fromCountMetric(s.batches);
let merges = CountValue.fromCountMetric(s.merges);
let steps = CountValue.fromCountMetric(s.steps);
return [
new Measurement(metric_id + ".avg_step_time", Option.some(avg_step_time)),
result.push(
new Measurement(metric_id + ".batches", Option.some(batches)),
new Measurement(metric_id + ".merges", Option.some(merges)),
new Measurement(metric_id + ".steps", Option.some(steps)),
];
);
return result;
}
case "policy": {
let s = metric.value as StringMetricValue;
Expand Down