pytest: fix test_automated_checkpoint_sync1 race against empty initial sync#6552
Merged
Conversation
sync Explicitly wait for a checkpoint with items >= processed. Signed-off-by: Abhinav Gyawali <22275402+abhizer@users.noreply.github.com>
c3a4b4f to
833e219
Compare
mythical-fred
approved these changes
Jun 27, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
Clean race fix. The old call to _wait_for_automated_sync() with no anchor would happily return on a stale/empty initial sync that completed before the manual checkpoint became visible — explicitly anchoring against the latest checkpoint whose cumulative processed_records >= processed closes that window. The 2 * ft_interval timeout for _latest_checkpoint is sensible (manual checkpoint(wait=True) should make it visible essentially immediately, and ft_interval=5s gives 10s of headroom).
The test_output_buffer_size_limit.py change is parens-only; no behavioral change.
Signed-off-by: Abhinav Gyawali <22275402+abhizer@users.noreply.github.com>
ryzhyk
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly wait for a checkpoint with items >= processed.