[web-console] Add memory pressure indicator to memory graph#6534
Merged
Conversation
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
Contributor
|
Can the graphs somehow show the upper limit too? |
mihaibudiu
approved these changes
Jun 24, 2026
mythical-fred
approved these changes
Jun 24, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
Small, focused change. The pressure chip on PipelineMemoryGraph and the badge bump on the Performance tab when memory pressure is high or critical are both the right shape — wiring global.memory_pressure through as an optional prop keeps the graph component reusable, and the pressureChips lookup table is a clean way to map the four pressure levels to display label + Tailwind class. low resolving to a hidden chip rather than a conditional {#if} is a fine tradeoff.
A few small things:
runtimeErrorsCount = connectorsWithErrorsCount + memoryPressureErrorCountconflates two different signals into a single integer badge. A user looking at a "2" badge can't tell whether that's "2 connector errors" or "1 connector + memory pressure." For now this is fine because the breakdown is visible inside the panel, but if a third "runtime issue" source ever appears the badge becomes a meaningless count. Worth a comment noting the badge is a "has issues" indicator and the number is approximate.- The
pressureChipsrecord uses'bg-error-50-950'for bothhighandcritical. Visually identical for the user; the only distinction comes from the label text. Was that intentional? Ifcriticalis meaningfully more severe (e.g., imminent OOM) thanhigh, a stronger color or a pulsing border would help users triage at a glance. - The
.devcontainer/devcontainer.jsonflip from"editor.formatOnSave": truetofalseis unrelated to memory pressure and probably belongs in a separate PR — easy to miss in review. Not blocking, just noting it. - Type import comes from
$lib/services/managerwhile the existing pipeline type comes from$lib/services/pipelineManager— slightly confusing aliasing, but consistent with what's already there. - The
multihostMemoryLimitMbchange is pure formatting (adding parens around the conditional expression). Biome reflow — fine.
mihaibudiu already approved. I won't block on the nits above. APPROVE.
Contributor
Author
They already do when the Y axis is scaled appropriately |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High and Critical memory pressure adds to the "Runtime" tab label error count
Fix #6309
Testing: manual. Unit test is unnecessary