[SQL] Advance Calcite version#6532
Merged
Merged
Conversation
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
mihaibudiu
enabled auto-merge
June 24, 2026 06:23
abhizer
approved these changes
Jun 24, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jun 24, 2026
mythical-fred
approved these changes
Jun 24, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
LGTM. One-line bump of CALCITE_NEXT_COMMIT to pick up the upstream fix for CALCITE-7619 (referenced from #6531). No risk on the Feldera side — CALCITE_NEXT is the prep pointer for the next Calcite import, not the active version. CI green.
…R BY ALL Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
mihaibudiu
enabled auto-merge
June 24, 2026 15:54
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jun 24, 2026
mythical-fred
approved these changes
Jun 24, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
Docs commit looks correct.
GROUP BY ALLparagraph matches the Calcite semantics ("group by every expression in the SELECT clause that is not an aggregate function"); the worked example is right.DISTINCT ONdescription correctly notes theORDER BYprefix constraint.ORDER BY ALLparagraph is accurate; the trailing-modifier note is a nice touch.- One small prose nit (non-blocking): "When using
DISTINCT ON, the expressions in theDISTINCT ONclause must match a prefix of theORDER BYclause." — would read more naturally as "theORDER BYclause must start with theDISTINCT ONexpressions". The current wording is technically right but inverts the agent of the constraint. includeDistinctOn: trueinconfig.fmppis the obvious enablement flag.
Prior APPROVE stands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6531