[SQL] Use stepWeightOne in more tests#6512
Queued
mihaibudiu wants to merge 1 commit into
Queued
Conversation
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
mythical-fred
approved these changes
Jun 20, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
LGTM — pure cosmetic test refactor swapping step with explicit weight columns for stepWeightOne. All seven files preserve the row counts and contents; the weight column is gone but only in cases where every row would have had weight 1, which is exactly what stepWeightOne asserts.
lalithsuresh
approved these changes
Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a cosmetic rewrite of some Java tests.
It was a commit in a larger PR, but since that one is not reviewed, I pulled it out.